Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 953283004: Make ComputeReceiverForNonGlobal faster (Closed)

Created:
5 years, 10 months ago by Jakob Kummerow
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make ComputeReceiverForNonGlobal faster by checking instance type rather than constructor. BUG=chromium:461734 LOG=n R=verwaest@chromium.org Committed: https://crrev.com/c8479785fc795f29f78c3abe879815fcb5d905ee Cr-Commit-Position: refs/heads/master@{#26856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/runtime/runtime-scopes.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
PTAL
5 years, 10 months ago (2015-02-25 14:12:22 UTC) #1
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-25 14:31:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953283004/1
5 years, 10 months ago (2015-02-25 15:02:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 15:24:35 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:24:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8479785fc795f29f78c3abe879815fcb5d905ee
Cr-Commit-Position: refs/heads/master@{#26856}

Powered by Google App Engine
This is Rietveld 408576698