Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 953283002: Chromecast: moves all service startup code to PreMainMessageLoopRun. (Closed)

Created:
5 years, 10 months ago by gunsch
Modified:
5 years, 10 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@metrics-cellular
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: moves all service startup code to PreMainMessageLoopRun. On Android, CastService::Start is never called (!). This is because Android uses a Java-based UI message loop after BrowserMainRunner::Initialize is completed, and BrowserMainRunner:Run is never called (nor should it be). See ChromeBrowserMainParts for similar handling of the Android case. R=lcwu@chromium.org,byungchul@chromium.org BUG=internal b/18934906 Committed: https://crrev.com/ec6d20ecb9586de310cf524ec1cfa1c0111a9427 Cr-Commit-Position: refs/heads/master@{#318136}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 4 chunks +15 lines, -2 lines 2 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 10 months ago (2015-02-25 06:27:56 UTC) #1
lcwu1
https://codereview.chromium.org/953283002/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/953283002/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode285 chromecast/browser/cast_browser_main_parts.cc:285: cast_browser_process_.reset(); Where does the tear-down of the cast objects ...
5 years, 10 months ago (2015-02-25 21:48:27 UTC) #2
gunsch
https://codereview.chromium.org/953283002/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/953283002/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode285 chromecast/browser/cast_browser_main_parts.cc:285: cast_browser_process_.reset(); On 2015/02/25 21:48:27, lcwu1 wrote: > Where does ...
5 years, 10 months ago (2015-02-25 21:58:57 UTC) #3
lcwu1
lgtm
5 years, 10 months ago (2015-02-25 22:21:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953283002/1
5 years, 10 months ago (2015-02-25 22:26:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 23:10:27 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 23:12:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec6d20ecb9586de310cf524ec1cfa1c0111a9427
Cr-Commit-Position: refs/heads/master@{#318136}

Powered by Google App Engine
This is Rietveld 408576698