Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 953273002: Update the Drive state in Files app when the refresh token is fetched. (Closed)

Created:
5 years, 10 months ago by mtomasz
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the Drive state in Files app when the refresh token is fetched. Before, we were not notifying Files app about such fact, so it was still thinking that Drive is not available, and showing the banner. TEST=Tested manually when logging to an empty profile. BUG=461247 Committed: https://crrev.com/eaffcdbc813caebe3160789ed9ecc503b5276926 Cr-Commit-Position: refs/heads/master@{#317995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 10 months ago (2015-02-25 05:37:17 UTC) #2
hirono
lgtm!
5 years, 10 months ago (2015-02-25 05:46:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953273002/1
5 years, 10 months ago (2015-02-25 05:52:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 06:13:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 06:13:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaffcdbc813caebe3160789ed9ecc503b5276926
Cr-Commit-Position: refs/heads/master@{#317995}

Powered by Google App Engine
This is Rietveld 408576698