Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 953243002: Cleanup BrowserPlugin (Closed)

Created:
5 years, 10 months ago by Fady Samuel
Modified:
5 years, 10 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup BrowserPlugin BrowserPluginHostMsg_Attach_Params took in both a size and an origin before this patch. It seems simpler to pass a view_rect instead. BUG=none TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change. Committed: https://crrev.com/49745bbf3e2dc37bd4218389c9a9c3a610a82889 Cr-Commit-Position: refs/heads/master@{#318096}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -23 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 6 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Fady Samuel
5 years, 10 months ago (2015-02-25 01:25:28 UTC) #2
paulmeyer
lgtm
5 years, 10 months ago (2015-02-25 14:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953243002/1
5 years, 10 months ago (2015-02-25 18:44:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/62103)
5 years, 10 months ago (2015-02-25 18:50:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953243002/20001
5 years, 10 months ago (2015-02-25 19:02:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 20:07:39 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:08:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49745bbf3e2dc37bd4218389c9a9c3a610a82889
Cr-Commit-Position: refs/heads/master@{#318096}

Powered by Google App Engine
This is Rietveld 408576698