Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: remoting/webapp/crd/js/fallback_signal_strategy.js

Issue 953223002: Include time elapsed since start of a remoting session in each log entry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Record elapsed time every time we log something. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/crd/js/log_to_server.js » ('j') | remoting/webapp/crd/js/log_to_server.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/fallback_signal_strategy.js
diff --git a/remoting/webapp/crd/js/fallback_signal_strategy.js b/remoting/webapp/crd/js/fallback_signal_strategy.js
index 030bfb42729197a4e735299d489d7490f788ff38..77fad2ef9d418315e85e9db326d7665a76f21d86 100644
--- a/remoting/webapp/crd/js/fallback_signal_strategy.js
+++ b/remoting/webapp/crd/js/fallback_signal_strategy.js
@@ -117,11 +117,6 @@ remoting.FallbackSignalStrategy = function(primary,
*/
this.connectionSetupResults_ = [];
- /**
- * @type {number}
- * @private
- */
- this.startTime_ = 0;
};
/**
@@ -178,7 +173,6 @@ remoting.FallbackSignalStrategy.prototype.connect =
this.username_ = username;
this.authToken_ = authToken;
this.state_ = this.State.PRIMARY_PENDING;
- this.startTime_ = new Date().getTime();
this.primary_.setIncomingStanzaCallback(this.onIncomingStanzaCallback_);
this.primary_.connect(server, username, authToken);
this.primaryConnectTimerId_ =
@@ -211,8 +205,7 @@ remoting.FallbackSignalStrategy.prototype.sendConnectionSetupResultsInternal_ =
for (var i = 0; i < this.connectionSetupResults_.length; ++i) {
var result = this.connectionSetupResults_[i];
this.logToServer_.logSignalStrategyProgress(result.strategyType,
- result.progress,
- result.elapsed);
+ result.progress);
}
this.connectionSetupResults_ = [];
};
@@ -391,8 +384,7 @@ remoting.FallbackSignalStrategy.prototype.updateProgress_ = function(
progress);
this.connectionSetupResults_.push({
'strategyType': strategy.getType(),
- 'progress': progress,
- 'elapsed': new Date().getTime() - this.startTime_
+ 'progress': progress
});
if (this.logToServer_) {
this.sendConnectionSetupResultsInternal_();
« no previous file with comments | « no previous file | remoting/webapp/crd/js/log_to_server.js » ('j') | remoting/webapp/crd/js/log_to_server.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698