Include time elapsed since start of a remoting session in each log entry.

remoting/webapp/crd/js/server_log_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A class of server log entries.
  *
  * Any changes to the values here need to be coordinated with the host and
  * server/log proto code.
@@ skipping 31 matching lines @@
 /** @private */
 remoting.ServerLogEntry.KEY_CONNECTION_TYPE_ = 'connection-type';
 /** @private */
 remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_TYPE_ = 'signal-strategy-type';
 /** @private */
 remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_PROGRESS_ =
     'signal-strategy-progress';
 /** @private */
 remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_ELAPSED_TIME_ =
     'signal-strategy-elapsed-time';
+/** @private */
+remoting.ServerLogEntry.EVENT_TOTAL_TIME_FOR_INITIAL_CONNECT_MS_ =
+    'total-time-for-initial-connect';

[Jamie, 2015/02/25 21:12:35]

I don't think we should need a separate log entry for this. We already have
session-state, and what we're interested in here is the time taken to reach a
certain state. It would be better to add an elapsed-time field to session-state
events (we already have one for signal-strategy-progress--you can either
duplicate it or rename it), I think, and then filter on the one we're interested
in.

[anandc, 2015/02/26 20:21:49]

Done.

+
+
 
 /**
  * @private
  * @param {remoting.ClientSession.State} state
  * @return {string}
  */
 remoting.ServerLogEntry.getValueForSessionState_ = function(state) {
   switch(state) {
     case remoting.ClientSession.State.UNKNOWN:
       return 'unknown';
@@ skipping 246 matching lines @@
  * @param {remoting.StatsAccumulator} statsAccumulator
  * @return {boolean} whether the statistic is non-zero
  */
 remoting.ServerLogEntry.prototype.addStatsField_ = function(
     entryKey, statsKey, statsAccumulator) {
   var val = statsAccumulator.calcMean(statsKey);
   this.set_(entryKey, val.toFixed(2));
   return (val != 0);
 };
 
+
+/**
+ * Makes a log entry for a "total connection time" event.
+ *
+ * @param {string} sessionId
+ * @param {remoting.DesktopConnectedView.Mode} mode
+ * @param {number} connectionTimeInMs
+ * @return {remoting.ServerLogEntry}
+ */
+remoting.ServerLogEntry.makeTotalTimeForInitialConnection =
+  function(sessionId, mode, connectionTimeInMs) {
+  var entry = new remoting.ServerLogEntry();
+  entry.set_(remoting.ServerLogEntry.KEY_ROLE_,
+             remoting.ServerLogEntry.VALUE_ROLE_CLIENT_);
+  entry.set_(
+      remoting.ServerLogEntry.KEY_EVENT_NAME_,
+      remoting.ServerLogEntry.EVENT_TOTAL_TIME_FOR_INITIAL_CONNECT_MS_);
+  entry.set_(remoting.ServerLogEntry.EVENT_TOTAL_TIME_FOR_INITIAL_CONNECT_MS_,
+             String(connectionTimeInMs));
+  entry.addSessionIdField(sessionId);
+  entry.addModeField(mode);
+  return entry;
+};
+
+
 /**
  * Makes a log entry for a "this session ID is old" event.
  *
  * @param {string} sessionId
  * @param {remoting.DesktopConnectedView.Mode} mode
  * @return {remoting.ServerLogEntry}
  */
 remoting.ServerLogEntry.makeSessionIdOld = function(sessionId, mode) {
   var entry = new remoting.ServerLogEntry();
   entry.set_(remoting.ServerLogEntry.KEY_ROLE_,
@@ skipping 180 matching lines @@
     case remoting.DesktopConnectedView.Mode.IT2ME:
       return remoting.ServerLogEntry.VALUE_MODE_IT2ME_;
     case remoting.DesktopConnectedView.Mode.ME2ME:
       return remoting.ServerLogEntry.VALUE_MODE_ME2ME_;
     case remoting.DesktopConnectedView.Mode.APP_REMOTING:
       return remoting.ServerLogEntry.VALUE_MODE_APP_REMOTING_;
     default:
       return remoting.ServerLogEntry.VALUE_MODE_UNKNOWN_;
   }
 };