Include time elapsed since start of a remoting session in each log entry.

remoting/webapp/crd/js/server_log_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A class of server log entries.
  *
  * Any changes to the values here need to be coordinated with the host and
  * server/log proto code.
@@ skipping 29 matching lines @@
 /** @private */
 remoting.ServerLogEntry.KEY_SESSION_STATE_ = 'session-state';
 /** @private */
 remoting.ServerLogEntry.KEY_CONNECTION_TYPE_ = 'connection-type';
 /** @private */
 remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_TYPE_ = 'signal-strategy-type';
 /** @private */
 remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_PROGRESS_ =
     'signal-strategy-progress';
 /** @private */
-remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_ELAPSED_TIME_ =
-    'signal-strategy-elapsed-time';
+remoting.ServerLogEntry.KEY_TIME_TO_REACH_A_SESSION_STATE_MS_ =
+    'time-to-reach-state';

[Jamie, 2015/02/26 20:32:06]

I think simply "elapsed-time" is a better name for this, as it need not refer to
a session state change event.

[anandc, 2015/02/26 22:47:11]

Done.

+
+
 
 /**
  * @private
  * @param {remoting.ClientSession.State} state
  * @return {string}
  */
 remoting.ServerLogEntry.getValueForSessionState_ = function(state) {
   switch(state) {
     case remoting.ClientSession.State.UNKNOWN:
       return 'unknown';
@@ skipping 246 matching lines @@
  * @param {remoting.StatsAccumulator} statsAccumulator
  * @return {boolean} whether the statistic is non-zero
  */
 remoting.ServerLogEntry.prototype.addStatsField_ = function(
     entryKey, statsKey, statsAccumulator) {
   var val = statsAccumulator.calcMean(statsKey);
   this.set_(entryKey, val.toFixed(2));
   return (val != 0);
 };
 
+

[Jamie, 2015/02/26 20:32:06]

No need for an extra blank line here.

[anandc, 2015/02/26 22:47:11]

Done.

 /**
  * Makes a log entry for a "this session ID is old" event.
  *
  * @param {string} sessionId
  * @param {remoting.DesktopConnectedView.Mode} mode
  * @return {remoting.ServerLogEntry}
  */
 remoting.ServerLogEntry.makeSessionIdOld = function(sessionId, mode) {
   var entry = new remoting.ServerLogEntry();
   entry.set_(remoting.ServerLogEntry.KEY_ROLE_,
@@ skipping 36 matching lines @@
     function(sessionId, strategyType, progress, elapsedTimeInMs) {
   var entry = new remoting.ServerLogEntry();
   entry.set_(remoting.ServerLogEntry.KEY_ROLE_,
              remoting.ServerLogEntry.VALUE_ROLE_CLIENT_);
   entry.set_(
       remoting.ServerLogEntry.KEY_EVENT_NAME_,
       remoting.ServerLogEntry.VALUE_EVENT_NAME_SIGNAL_STRATEGY_PROGRESS_);
   entry.addSessionIdField(sessionId);
   entry.set_(remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_TYPE_, strategyType);
   entry.set_(remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_PROGRESS_, progress);
-  entry.set_(remoting.ServerLogEntry.KEY_SIGNAL_STRATEGY_ELAPSED_TIME_,
-             String(elapsedTimeInMs));
 
   return entry;
 };
 
 /**
  * Adds a session ID field to this log entry.
  *
  * @param {string} sessionId
  */
 remoting.ServerLogEntry.prototype.addSessionIdField = function(sessionId) {
@@ skipping 74 matching lines @@
     return {
         'os_name': remoting.ServerLogEntry.VALUE_OS_NAME_CHROMEOS_,
         'os_version': match[2],
         'cpu': match[1]
     };
   }
   return null;
 };
 
 /**
+ * Adds a field to this log entry specifying the elapsed time since the start of
+ * the session to the current session state.
+ * @param {number} elapsedTimeInMs
+ */
+remoting.ServerLogEntry.prototype.addTimeToReachStateMs =
+    function(elapsedTimeInMs) {
+    this.set_(remoting.ServerLogEntry.KEY_TIME_TO_REACH_A_SESSION_STATE_MS_,
+              String(elapsedTimeInMs));
+};
+
+
+/**
  * Adds a field specifying the browser version to this log entry.
  */
 remoting.ServerLogEntry.prototype.addChromeVersionField = function() {
   var version = remoting.getChromeVersion();
   if (version != null) {
     this.set_(remoting.ServerLogEntry.KEY_BROWSER_VERSION_, version);
   }
 };
 
 /**
@@ skipping 28 matching lines @@
     case remoting.DesktopConnectedView.Mode.IT2ME:
       return remoting.ServerLogEntry.VALUE_MODE_IT2ME_;
     case remoting.DesktopConnectedView.Mode.ME2ME:
       return remoting.ServerLogEntry.VALUE_MODE_ME2ME_;
     case remoting.DesktopConnectedView.Mode.APP_REMOTING:
       return remoting.ServerLogEntry.VALUE_MODE_APP_REMOTING_;
     default:
       return remoting.ServerLogEntry.VALUE_MODE_UNKNOWN_;
   }
 };