Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 953063003: Revert of Roll ASan/Win to LLVM r229860 (Closed)

Created:
5 years, 10 months ago by inferno
Modified:
5 years, 10 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll ASan/Win to LLVM r229860 (patchset #1 id:1 of https://codereview.chromium.org/911323004/) Reason for revert: Probable reason for Sanitizer CHECK failure in CHECK failed: "((curr_thread)) != (0)" (0x0, 0x0) BUG=414136, 459722 Original issue's description: > Roll ASan/Win to LLVM r229860 > > This should fix > BUG=459722 > > Please note I'm rolling this without waiting for the ASan/Win FYI bot to cycle > (takes ~4 hours) to reduce the time it takes the LKGR ASan builder to turn green > (assuming r229860 is most likely OK). If it isn't OK, we'll need to roll once > again when we know the next stable LLVM revision. > > TBR=inferno@chromium.org > NOTRY=true > > Committed: https://crrev.com/fea6440d7458b483d1e230be5e27a5a90e077a80 > Cr-Commit-Position: refs/heads/master@{#317056} TBR=timurrrr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7e94fd20fcd956162a62d8e7b35b14f76deba495 Cr-Commit-Position: refs/heads/master@{#317880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
inferno
Created Revert of Roll ASan/Win to LLVM r229860
5 years, 10 months ago (2015-02-24 20:33:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953063003/1
5 years, 10 months ago (2015-02-24 20:35:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 20:36:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7e94fd20fcd956162a62d8e7b35b14f76deba495 Cr-Commit-Position: refs/heads/master@{#317880}
5 years, 10 months ago (2015-02-24 20:38:15 UTC) #4
Timur Iskhodzhanov
LGTM
5 years, 10 months ago (2015-02-25 14:17:15 UTC) #5
Timur Iskhodzhanov
5 years, 9 months ago (2015-02-27 14:18:02 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/965763002/ by timurrrr@chromium.org.

The reason for reverting is: It didn't help, see
https://code.google.com/p/chromium/issues/detail?id=414136#c28.

Powered by Google App Engine
This is Rietveld 408576698