Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 953053002: SkPDF: remove SK_API on no-longer-public functions. (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: remove SK_API on no-longer-public functions. CQ_INCLUDE_TRYBOTS=client.skia:Mac Builder-Trybot,Linux Builder-Trybot,Win Builder-Trybot Committed: https://skia.googlesource.com/skia/+/4e4e8160459f68c1795f2297bcec6f7866e01fa8

Patch Set 1 #

Patch Set 2 : Rebase: 2015-02-24 (Tuesday) 18:48:48 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/pdf/SkPDFDevice.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M src/pdf/SkPDFDocument.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/pdf/SkPDFFontImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953053002/1
5 years, 10 months ago (2015-02-24 19:52:25 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-24 19:52:26 UTC) #3
hal.canary
ptal
5 years, 10 months ago (2015-02-25 16:37:50 UTC) #6
mtklein
lgtm
5 years, 10 months ago (2015-02-25 16:47:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953053002/20001
5 years, 10 months ago (2015-02-25 16:47:43 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 16:59:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4e4e8160459f68c1795f2297bcec6f7866e01fa8

Powered by Google App Engine
This is Rietveld 408576698