Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 953003004: extensions: allow trash to have a focus outline. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions: allow trash to have a focus outline. This makes more sense when its an inline element in the page, accessible by keyboard or mouse focus. On chrome://apps its not possible to focus this element as far as I know, as its only shown while dragging. R=estade@chromium.org BUG=456706 TEST=visual, see bug

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -30 lines) Patch
M chrome/browser/resources/extensions/extension_list.js View 5 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/css/trash.css View 1 chunk +51 lines, -21 lines 0 comments Download
M ui/webui/resources/html/trash.html View 1 chunk +4 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698