Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 953003003: [Extensions] Merge developerPrivate.enable and management.setEnabled functions (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Merge developerPrivate.enable and management.setEnabled functions developerPrivate.enable didn't do anything that management.setEnabled didn't. Simply map developerPrivate.enable to management.setEnabled. BUG=461039 NOTRY=true Committed: https://crrev.com/383bc12e65a39fbecb91f998c49dbab66573f128 Cr-Commit-Position: refs/heads/master@{#318268}

Patch Set 1 #

Patch Set 2 : Latest master #

Patch Set 3 : Test fix #

Patch Set 4 : histograms.xml #

Patch Set 5 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -104 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 2 chunks +0 lines, -72 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/developer_private_custom_bindings.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/developer/test/manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (14 generated)
Devlin
5 years, 10 months ago (2015-02-24 17:27:47 UTC) #2
not at google - send to devlin
lgtm, and +sergeygs as an FYI. I presume you've tested the ADT.
5 years, 10 months ago (2015-02-24 17:51:40 UTC) #4
Devlin
On 2015/02/24 17:51:40, kalman wrote: > lgtm, and +sergeygs as an FYI. I presume you've ...
5 years, 10 months ago (2015-02-24 18:26:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953003003/60001
5 years, 10 months ago (2015-02-25 20:31:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45530)
5 years, 10 months ago (2015-02-25 21:06:38 UTC) #11
Devlin
Mark, mind checking the histogram value?
5 years, 10 months ago (2015-02-25 21:09:59 UTC) #13
Mark P
where's the xml file?
5 years, 10 months ago (2015-02-25 21:16:17 UTC) #14
Devlin
On 2015/02/25 21:16:17, Mark P wrote: > where's the xml file? Whoops! I always forget ...
5 years, 10 months ago (2015-02-25 21:58:26 UTC) #15
Mark P
histograms.xml lgtm
5 years, 10 months ago (2015-02-25 22:58:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953003003/80001
5 years, 10 months ago (2015-02-25 23:06:50 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45610)
5 years, 10 months ago (2015-02-25 23:30:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953003003/80001
5 years, 10 months ago (2015-02-26 00:20:18 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45640)
5 years, 10 months ago (2015-02-26 00:38:46 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953003003/100001
5 years, 10 months ago (2015-02-26 18:36:37 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 10 months ago (2015-02-26 18:38:04 UTC) #29
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:39:11 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/383bc12e65a39fbecb91f998c49dbab66573f128
Cr-Commit-Position: refs/heads/master@{#318268}

Powered by Google App Engine
This is Rietveld 408576698