Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 952993006: Omit textual emitConstPool in MINIMAL build. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
kschimpf, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Omit textual emitConstPool in MINIMAL build. Noticed the "Note: Still used by emit IAS" and decided to check if we can omit it. Saves about 3KB. There's also the "Note: Still used by emit IAS" CFG text header, but I haven't looked at that. This would silently cripple the -filetype=asm or -filetype=iasm in the MINIMAL build, but that isn't supposed to be supported. Had to conditionalize some more of the tests. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4080 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b5447a0488d8c33b5e2b35902b6865fc275ca6d1

Patch Set 1 #

Patch Set 2 : line wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -25 lines) Patch
M pydir/run-llvm2ice.py View 3 chunks +7 lines, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/arith-opt.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/elf_container.ll View 1 1 chunk +8 lines, -6 lines 0 comments Download
M tests_lit/llvm2ice_tests/elf_function_sections.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/elf_nodata.ll View 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpconst.pnacl.ll View 1 chunk +11 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/nop-insertion.ll View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-24 22:52:04 UTC) #2
Jim Stichnoth
LGTM. All textual emission is expressly not supported in the MINIMAL mode, since the minimal ...
5 years, 10 months ago (2015-02-25 00:07:40 UTC) #3
jvoung (off chromium)
5 years, 10 months ago (2015-02-25 00:57:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b5447a0488d8c33b5e2b35902b6865fc275ca6d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698