Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 952993003: [android] Handle unknown country codes. (Closed)

Created:
5 years, 10 months ago by please use gerrit instead
Modified:
5 years, 10 months ago
Reviewers:
Evan Stade, newt (away)
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, Theresa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Handle unknown country codes. Don't show "Kosovo" (country code "XK") as an autofill country name option on K devices, because K devices are not aware of it. Add "XK" to the list of autofill countries to enable saving autofill profiles with country name "Kosovo." BUG=456246 Committed: https://crrev.com/6dbf9a7fd446cff4c478df2396e1b6b57d96ac77 Cr-Commit-Position: refs/heads/master@{#318103}

Patch Set 1 #

Total comments: 2

Patch Set 2 : known_country_names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc View 1 2 chunks +16 lines, -11 lines 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
please use gerrit instead
Evan, PTAL.
5 years, 10 months ago (2015-02-24 18:51:47 UTC) #2
Evan Stade
lgtm
5 years, 10 months ago (2015-02-25 01:57:12 UTC) #3
please use gerrit instead
Newton, OWNERS PTAL chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc
5 years, 10 months ago (2015-02-25 17:36:38 UTC) #4
please use gerrit instead
Newton, OWNERS PTAL chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc
5 years, 10 months ago (2015-02-25 17:36:55 UTC) #6
newt (away)
lgtm https://codereview.chromium.org/952993003/diff/1/chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc File chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc (right): https://codereview.chromium.org/952993003/diff/1/chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc#newcode72 chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc:72: country_names.push_back(country_name); suggestion: renaming this to known_country_names might make ...
5 years, 10 months ago (2015-02-25 18:49:27 UTC) #7
please use gerrit instead
Sending to cq... https://codereview.chromium.org/952993003/diff/1/chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc File chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc (right): https://codereview.chromium.org/952993003/diff/1/chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc#newcode72 chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc:72: country_names.push_back(country_name); On 2015/02/25 18:49:27, newt wrote: ...
5 years, 10 months ago (2015-02-25 19:38:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952993003/20001
5 years, 10 months ago (2015-02-25 19:39:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 20:25:57 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:26:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6dbf9a7fd446cff4c478df2396e1b6b57d96ac77
Cr-Commit-Position: refs/heads/master@{#318103}

Powered by Google App Engine
This is Rietveld 408576698