Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 952963002: Revert of [Telemetry] Update facebook credential & reenable memory.top_7_stress (Closed)

Created:
5 years, 10 months ago by nednguyen
Modified:
5 years, 10 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org, petrcermak, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Update facebook credential & reenable memory.top_7_stress (patchset #1 id:1 of https://codereview.chromium.org/951773002/) Reason for revert: Forgot to upload the wpr archive. Both the reference build & current one are failing: http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/9347 Original issue's description: > [Telemetry] Update facebook credential & re-record the facebook page in top_7_stress & reenable memory.top_7_stress. > > BUG=459646 > TEST=./tools/perf/run_benchmark memory.top_7_stress --browser=system > > Committed: https://crrev.com/86c9a9b5470c3c1292fc7a8e7e276045ab0f512c > Cr-Commit-Position: refs/heads/master@{#317793} TBR=dtu@chromium.org,sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459646 Committed: https://crrev.com/ec6f9bdbba4e9e97d788de0e4915f65166dfb689 Cr-Commit-Position: refs/heads/master@{#317804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/data/top_7_stress.json View 2 chunks +1 line, -3 lines 0 comments Download
D tools/perf/page_sets/data/top_7_stress_003.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nednguyen
Created Revert of [Telemetry] Update facebook credential & reenable memory.top_7_stress
5 years, 10 months ago (2015-02-24 15:55:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952963002/1
5 years, 10 months ago (2015-02-24 15:56:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 15:57:30 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 15:58:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec6f9bdbba4e9e97d788de0e4915f65166dfb689
Cr-Commit-Position: refs/heads/master@{#317804}

Powered by Google App Engine
This is Rietveld 408576698