Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 952933002: Use a hashmap to lookup items in the partial snapshot cache when serializing. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use a hashmap to lookup items in the partial snapshot cache when serializing. R=vogelheim@chromium.org Committed: https://crrev.com/c18de6024875361f6e994b69fd6d86a234e0185d Cr-Commit-Position: refs/heads/master@{#26839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M src/serialize.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 10 months ago (2015-02-24 15:17:41 UTC) #1
Yang
On 2015/02/24 15:17:41, Yang wrote: This speeds up serializing mobilenatives_android.js from 1715ms to 1360ms.
5 years, 10 months ago (2015-02-24 15:19:02 UTC) #2
vogelheim
lgtm
5 years, 10 months ago (2015-02-24 15:42:35 UTC) #3
vogelheim
On 2015/02/24 15:19:02, Yang wrote: > On 2015/02/24 15:17:41, Yang wrote: > > This speeds ...
5 years, 10 months ago (2015-02-24 15:42:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952933002/1
5 years, 10 months ago (2015-02-25 07:18:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 07:49:28 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 07:49:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c18de6024875361f6e994b69fd6d86a234e0185d
Cr-Commit-Position: refs/heads/master@{#26839}

Powered by Google App Engine
This is Rietveld 408576698