Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 95293003: Fix context register allocation in LTransitionElementsKind. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4345 matching lines...) Expand 10 before | Expand all | Expand 10 after
4356 __ j(not_equal, &not_applicable); 4356 __ j(not_equal, &not_applicable);
4357 if (IsSimpleMapChangeTransition(from_kind, to_kind)) { 4357 if (IsSimpleMapChangeTransition(from_kind, to_kind)) {
4358 Register new_map_reg = ToRegister(instr->new_map_temp()); 4358 Register new_map_reg = ToRegister(instr->new_map_temp());
4359 __ movq(new_map_reg, to_map, RelocInfo::EMBEDDED_OBJECT); 4359 __ movq(new_map_reg, to_map, RelocInfo::EMBEDDED_OBJECT);
4360 __ movq(FieldOperand(object_reg, HeapObject::kMapOffset), new_map_reg); 4360 __ movq(FieldOperand(object_reg, HeapObject::kMapOffset), new_map_reg);
4361 // Write barrier. 4361 // Write barrier.
4362 ASSERT_NE(instr->temp(), NULL); 4362 ASSERT_NE(instr->temp(), NULL);
4363 __ RecordWriteField(object_reg, HeapObject::kMapOffset, new_map_reg, 4363 __ RecordWriteField(object_reg, HeapObject::kMapOffset, new_map_reg,
4364 ToRegister(instr->temp()), kDontSaveFPRegs); 4364 ToRegister(instr->temp()), kDontSaveFPRegs);
4365 } else { 4365 } else {
4366 ASSERT(ToRegister(instr->context()).is(rsi));
4366 PushSafepointRegistersScope scope(this); 4367 PushSafepointRegistersScope scope(this);
4367 if (!object_reg.is(rax)) { 4368 if (!object_reg.is(rax)) {
4368 __ movq(rax, object_reg); 4369 __ movq(rax, object_reg);
4369 } 4370 }
4370 LoadContextFromDeferred(instr->context());
4371 __ Move(rbx, to_map); 4371 __ Move(rbx, to_map);
4372 TransitionElementsKindStub stub(from_kind, to_kind); 4372 TransitionElementsKindStub stub(from_kind, to_kind);
4373 __ CallStub(&stub); 4373 __ CallStub(&stub);
4374 RecordSafepointWithRegisters( 4374 RecordSafepointWithRegisters(
4375 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt); 4375 instr->pointer_map(), 0, Safepoint::kNoLazyDeopt);
4376 } 4376 }
4377 __ bind(&not_applicable); 4377 __ bind(&not_applicable);
4378 } 4378 }
4379 4379
4380 4380
(...skipping 1258 matching lines...) Expand 10 before | Expand all | Expand 10 after
5639 FixedArray::kHeaderSize - kPointerSize)); 5639 FixedArray::kHeaderSize - kPointerSize));
5640 __ bind(&done); 5640 __ bind(&done);
5641 } 5641 }
5642 5642
5643 5643
5644 #undef __ 5644 #undef __
5645 5645
5646 } } // namespace v8::internal 5646 } } // namespace v8::internal
5647 5647
5648 #endif // V8_TARGET_ARCH_X64 5648 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698