Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 952893007: NaCl: Update revision in DEPS, 88ba651 -> d1999f5 (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
JF
CC:
chromium-reviews, bradn, Dirk Pranke, Derek Schuff, Mircea Trofin, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, 88ba651 -> d1999f5 This pulls in the following Native Client changes: 26f5754: (sbc@chromium.org) Revert "Implement pthread_rwlock functions for NaCl newlib." 641a0eb: (dpranke@chromium.org) Update GN build files w/ cpu_arch -> current_cpu changes 7168ea5: (mtrofin@chromium.org) Support for debug builds for host binaries (e.g. llvm) 123e556: (dschuff@chromium.org) Update revision for PNaCl d1999f5: (bradnelson@google.com) Reenabling crc32w. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build Committed: https://crrev.com/3794a7a029e698384d0e87c5913f26a071481b2c Cr-Commit-Position: refs/heads/master@{#318055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-25 15:11:11 UTC) #2
JF
lgtm (¬д¬。)
5 years, 10 months ago (2015-02-25 15:48:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952893007/1
5 years, 10 months ago (2015-02-25 15:56:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 16:15:17 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3794a7a029e698384d0e87c5913f26a071481b2c Cr-Commit-Position: refs/heads/master@{#318055}
5 years, 10 months ago (2015-02-25 16:15:48 UTC) #7
Sam Clegg
On 2015/02/25 16:15:48, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-02-25 16:57:56 UTC) #8
Sam Clegg
5 years, 10 months ago (2015-02-25 22:25:04 UTC) #9
Message was sent while issue was closed.
On 2015/02/25 16:57:56, Sam Clegg wrote:
> On 2015/02/25 16:15:48, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/3794a7a029e698384d0e87c5913f26a071481b2c
> > Cr-Commit-Position: refs/heads/master@{#318055}
> 
> Oops, looks like we didn't get the critical revision in this roll:
> 123e556 Update revision for PNaCl

Sorry.. I was parsing the commits as most recent first.. 123e556 is included
after all.

Powered by Google App Engine
This is Rietveld 408576698