Issue 952893006: Take the ScriptOrigin into account for CompileFunctionInContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 952893006: Take the ScriptOrigin into account for CompileFunctionInContext (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Take the ScriptOrigin into account for CompileFunctionInContext BUG=none R=yangguo@chromium.org LOG=n

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -5 lines)			Patch
M	src/api.cc	View	1 chunk	+24 lines, -1 line	0 comments	Download
M	src/compiler.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	3 chunks	+12 lines, -3 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

doesn't quite do what I want it to do yet... we need to throw exceptions ...

5 years, 9 months ago (2015-02-25 15:28:14 UTC) #2

yangguo

5 years, 9 months ago (2015-02-25 15:47:19 UTC) #3

On 2015/02/25 15:28:14, jochen (slow) wrote:
> doesn't quite do what I want it to do yet...
> 
> we need to throw exceptions when compilation fails, the function should claim
to
> be a function, not the result of eval, and the line numbers are sometimes
> off....

I think I used the ONLY_FUNCTION_LITERAL as signal that it comes from a function
constructor. If you look at its source, it wraps the function body, so that the
line offsets would be off. Devs complained so that in this case we use -1 as
column offset for correction.

Expand Messages | Collapse Messages