Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: mojo/tools/mopy/gn.py

Issue 952893003: Update from https://crrev.com/317530 (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix gn for nacl Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/tools/mopy/config.py ('k') | mojo/tools/mopy/gn_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mopy/gn.py
diff --git a/mojo/tools/mopy/gn.py b/mojo/tools/mopy/gn.py
index aeaa135059270c550573096800162fd64d09fe62..831711b7f210194fb3f04a1cbe9f35bdb3a528a5 100644
--- a/mojo/tools/mopy/gn.py
+++ b/mojo/tools/mopy/gn.py
@@ -22,8 +22,8 @@ def BuildDirectoryForConfig(config, src_root):
subdir = ""
if config.target_os == Config.OS_ANDROID:
subdir += "android_"
- if config.target_arch != Config.ARCH_ARM:
- subdir += config.target_arch + "_"
+ if config.target_cpu != Config.ARCH_ARM:
+ subdir += config.target_cpu + "_"
elif config.target_os == Config.OS_CHROMEOS:
subdir += "chromeos_"
subdir += "Debug" if config.is_debug else "Release"
@@ -72,7 +72,7 @@ def GNArgsForConfig(config):
gn_args["use_glib"] = False
gn_args["use_system_harfbuzz"] = False
- gn_args["target_arch"] = config.target_arch
+ gn_args["target_cpu"] = config.target_cpu
return gn_args
@@ -103,7 +103,7 @@ def ConfigForGNArgs(args):
config_args["goma_dir"] = args.get("goma_dir")
config_args["use_nacl"] = args.get("mojo_use_nacl", False)
config_args["target_os"] = args.get("os")
- config_args["target_arch"] = args.get("target_arch")
+ config_args["target_cpu"] = args.get("target_cpu")
config_args["dcheck_always_on"] = args.get("dcheck_always_on")
return Config(**config_args)
« no previous file with comments | « mojo/tools/mopy/config.py ('k') | mojo/tools/mopy/gn_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698