tools/clang/blink_gc_plugin/tests/traceimpl_error.txt - Issue 952893003: Update from https://crrev.com/317530

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/traceimpl_error.txt

Issue 952893003: Update from https://crrev.com/317530 (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fix gn for nacl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 In file included from traceimpl_error.cpp:5:

	2 ./traceimpl_error.h:23:3: warning: [blink-gc] Class 'TraceImplInlinedWithUntrace dMember' has untraced fields that require tracing.

	3 void traceImpl(VisitorDispatcher visitor) {

	4 ^

	5 ./traceimpl_error.h:28:3: note: [blink-gc] Untraced field 'x_' declared here:

	6 Member<X> x_;

	7 ^

	8 ./traceimpl_error.h:53:3: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplInlineWithUntracedBase' requires tracing.

	9 void traceImpl(VisitorDispatcher visitor) {

	10 ^

	11 traceimpl_error.cpp:14:1: warning: [blink-gc] Class 'TraceImplExternWithUntraced Member' has untraced fields that require tracing.

	12 inline void TraceImplExternWithUntracedMember::traceImpl(

	13 ^

	14 ./traceimpl_error.h:40:3: note: [blink-gc] Untraced field 'x_' declared here:

	15 Member<X> x_;

	16 ^

	17 traceimpl_error.cpp:24:1: warning: [blink-gc] Base class 'Base' of derived class 'TraceImplExternWithUntracedBase' requires tracing.

	18 inline void TraceImplExternWithUntracedBase::traceImpl(

	19 ^

	20 4 warnings generated.

OLD	NEW