Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 952863006: Simplify error message logic in ParseImportNames (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify error message logic in ParseImportNames The new logic ensures that the error messages are the same in the "import { <reserved word> }" and "import { foo as <reserved ord> }" cases. Also prepares ParseImportNames for returning both the import and local names to ParseImportClause. BUG=v8:1569 LOG=n Committed: https://crrev.com/8b33567fd37e3151d3ea707f7fb47b67196a5fc2 Cr-Commit-Position: refs/heads/master@{#26863}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -35 lines) Patch
M src/parser.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.cc View 1 6 chunks +23 lines, -18 lines 0 comments Download
A + test/message/import-as-eval.js View 1 chunk +1 line, -2 lines 0 comments Download
A test/message/import-as-eval.out View 1 chunk +7 lines, -0 lines 0 comments Download
A + test/message/import-as-reserved-word.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/message/import-as-reserved-word.out View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + test/message/import-eval.js View 1 chunk +1 line, -2 lines 0 comments Download
A test/message/import-eval.out View 1 chunk +7 lines, -0 lines 0 comments Download
A + test/message/import-reserved-word.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/message/import-reserved-word.out View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
adamk
5 years, 10 months ago (2015-02-25 00:07:10 UTC) #2
rossberg
lgtm
5 years, 10 months ago (2015-02-25 13:41:33 UTC) #3
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/952863006/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/952863006/diff/1/src/parser.cc#newcode1422 src/parser.cc:1422: Literal* module = ParseModuleSpecifier(CHECK_OK); nit: module_specifier
5 years, 10 months ago (2015-02-25 15:33:07 UTC) #4
adamk
https://codereview.chromium.org/952863006/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/952863006/diff/1/src/parser.cc#newcode1422 src/parser.cc:1422: Literal* module = ParseModuleSpecifier(CHECK_OK); On 2015/02/25 15:33:07, arv wrote: ...
5 years, 10 months ago (2015-02-25 19:02:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952863006/20001
5 years, 10 months ago (2015-02-25 19:04:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-25 19:40:44 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 19:41:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b33567fd37e3151d3ea707f7fb47b67196a5fc2
Cr-Commit-Position: refs/heads/master@{#26863}

Powered by Google App Engine
This is Rietveld 408576698