Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 952863003: Sync the NamedNodeMap interface with the spec (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the NamedNodeMap interface with the spec https://dom.spec.whatwg.org/#interface-namednodemap There are no changes to the generated code other than the order. The spec uses namespace as the argument name, but that causes the generated code to not compile, since it is a C++ keyword: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28093 BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M Source/core/dom/NamedNodeMap.idl View 1 chunk +10 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
philipj_slow
PTAL
5 years, 10 months ago (2015-02-24 16:51:48 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-24 17:01:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952863003/1
5 years, 10 months ago (2015-02-24 17:32:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/52156)
5 years, 10 months ago (2015-02-24 19:17:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952863003/1
5 years, 10 months ago (2015-02-25 03:24:38 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 04:27:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190801

Powered by Google App Engine
This is Rietveld 408576698