Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 952853002: Wallpaper manager now observing user child user status to update default wallpaper. (Closed)

Created:
5 years, 10 months ago by merkulova
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wallpaper manager now observing user child user status to update default wallpaper. BUG=461282 Committed: https://crrev.com/c3a3f671f8e0c5777c6bc825f21d61c6bcafbec3 Cr-Commit-Position: refs/heads/master@{#318666} Committed: https://crrev.com/ecce5a4cb71791f5dc1da50a4acbc1e46d6687fb Cr-Commit-Position: refs/heads/master@{#318697}

Patch Set 1 #

Patch Set 2 : Test fixed. #

Total comments: 2

Patch Set 3 : One more test fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 28 (10 generated)
merkulova
5 years, 10 months ago (2015-02-24 12:21:43 UTC) #2
bshe
On 2015/02/24 12:21:43, merkulova wrote: lgtm
5 years, 10 months ago (2015-02-24 14:21:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952853002/1
5 years, 10 months ago (2015-02-24 14:35:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/28706)
5 years, 10 months ago (2015-02-24 17:53:00 UTC) #7
merkulova
+skuhne@
5 years, 10 months ago (2015-02-25 10:24:12 UTC) #9
Mr4D (OOO till 08-26)
Sorry would have looked more for a better solution, but I am on a 2 ...
5 years, 10 months ago (2015-02-25 15:23:16 UTC) #10
merkulova
https://codereview.chromium.org/952853002/diff/20001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc File chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc (right): https://codereview.chromium.org/952853002/diff/20001/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc#newcode958 chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc:958: void WallpaperManager::UserChangedChildStatus(user_manager::User* user) { On 2015/02/25 15:23:16, Mr4D wrote: ...
5 years, 10 months ago (2015-02-25 15:30:14 UTC) #11
Mr4D (OOO till 08-26)
Sorry for the delay - was OOO. I assume that a supervised user cannot be ...
5 years, 9 months ago (2015-02-27 21:48:11 UTC) #12
merkulova
Right, SU are always out of Multiprofiles. Thank you
5 years, 9 months ago (2015-03-02 07:45:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952853002/20001
5 years, 9 months ago (2015-03-02 07:45:43 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 08:18:23 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c3a3f671f8e0c5777c6bc825f21d61c6bcafbec3 Cr-Commit-Position: refs/heads/master@{#318666}
5 years, 9 months ago (2015-03-02 08:19:16 UTC) #18
ulan
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/966333004/ by ulan@chromium.org. ...
5 years, 9 months ago (2015-03-02 09:24:28 UTC) #19
merkulova
Stefan, could you have one more look? Thanks
5 years, 9 months ago (2015-03-02 09:45:55 UTC) #22
Mr4D (OOO till 08-26)
lgtm
5 years, 9 months ago (2015-03-02 15:06:41 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952853002/80001
5 years, 9 months ago (2015-03-02 15:08:33 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 9 months ago (2015-03-02 15:49:22 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 15:50:11 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ecce5a4cb71791f5dc1da50a4acbc1e46d6687fb
Cr-Commit-Position: refs/heads/master@{#318697}

Powered by Google App Engine
This is Rietveld 408576698