Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: chrome/browser/signin/easy_unlock_service_signin_chromeos.cc

Issue 952833005: cros: Fix EasyUnlockServiceSignin::OnUserDataLoaded crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
diff --git a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc b/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
index 4fd94240095d84f57b2d6fa69e0a6335fda6d500..7fb3809b40603146b46376324c714c7289ee1a32 100644
--- a/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
+++ b/chrome/browser/signin/easy_unlock_service_signin_chromeos.cc
@@ -333,6 +333,10 @@ void EasyUnlockServiceSignin::OnUserDataLoaded(
const std::string& user_id,
bool success,
const chromeos::EasyUnlockDeviceKeyDataList& devices) {
+ // Bail out if this is called after service shuts down.
+ if (!service_active_)
tbarzic 2015/02/24 19:51:07 Won't invalidating weak ptrs in ShutDownInternal p
xiyuan 2015/02/24 20:25:53 You are right. The callback should not be called a
+ return;
+
allow_cryptohome_backoff_ = false;
UserData* data = user_data_[user_id_];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698