cros: Fix EasyUnlockServiceSignin::OnUserDataLoaded crash.

cros: Fix EasyUnlockServiceSignin::OnUserDataLoaded crash.

BUG=461408
Committed: https://crrev.com/a1f4fa340e8f240b60d991984c058e748e7e914d
Cr-Commit-Position: refs/heads/master@{#317882}

[xiyuan, 2015-02-24 19:05:15]

xiyuan@chromium.org changed reviewers:
+ tbarzic@chromium.org

[tbarzic, 2015-02-24 19:51:07]

https://codereview.chromium.org/952833005/diff/1/chrome/browser/signin/easy_u...
File chrome/browser/signin/easy_unlock_service_signin_chromeos.cc (right):

https://codereview.chromium.org/952833005/diff/1/chrome/browser/signin/easy_u...
chrome/browser/signin/easy_unlock_service_signin_chromeos.cc:337: if
(!service_active_)
Won't invalidating weak ptrs in ShutDownInternal prevent this from being called
after service is shut down?
What am I missing?

[xiyuan, 2015-02-24 20:25:53]

https://codereview.chromium.org/952833005/diff/1/chrome/browser/signin/easy_u...
File chrome/browser/signin/easy_unlock_service_signin_chromeos.cc (right):

https://codereview.chromium.org/952833005/diff/1/chrome/browser/signin/easy_u...
chrome/browser/signin/easy_unlock_service_signin_chromeos.cc:337: if
(!service_active_)
On 2015/02/24 19:51:07, tbarzic wrote:
> Won't invalidating weak ptrs in ShutDownInternal prevent this from being
called
> after service is shut down?
> What am I missing?

You are right. The callback should not be called after ShutdownInternal.

The problem is probably because we are using |user_id_| to get data but it has
changed after we start to load data. One possible case is there is no focused
user when the callback is invoked. We should always user |user_id| that is
passed in with the callback.

[tbarzic, 2015-02-24 20:29:40]

lgtm

[xiyuan, 2015-02-24 20:34:32]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2015-02-24 20:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952833005/20001

[commit-bot: I haz the power, 2015-02-24 20:55:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-24 20:56:10]

Patchset 2 (id:??) landed as
https://crrev.com/a1f4fa340e8f240b60d991984c058e748e7e914d
Cr-Commit-Position: refs/heads/master@{#317882}