Chromium Code Reviews Chromium Code Reviews
Issue
95283003:
Do not put allocated block into HeapObjectsMap (Closed)
DescriptionDo not put allocated block into HeapObjectsMap
Heap allocation reported to AllocationTracker may be later divided into several objects so it is incorrect to put the block as a new HeapObject into the map. We will match allocated block with actual HeapObjects later when iterating Heap (will be addressed in another patch). Since the objects are not assigned an id immediately after creation we need to call FindOrAddEntry when finding id for SharedFunctionInfo during stack crawling.
Removed hooks for tracking creation of AllocationMemento. AllocationMemento is not a HeapObject and should be considered as implementation overhead.
Renamed NewObjectEvent to AllocationEvent which is more precise in case of folded allocations and when a part of the new block becomes AllocationMemento.
BUG=None
LOG=N
R=loislo@chromium.org, mstarzinger@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=18151
Patch Set 1 #Patch Set 2 : Renamed NewObjectEvent #Patch Set 3 : Renamed NewObjectEvent #Patch Set 4 : Reupload #Patch Set 5 : Reupload2 #Patch Set 6 : Reupload take 3 #
Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
