Use a framed window on Mac.

Use a framed window on Mac.

Since Mac does not support transparency, having a window with no title bar is inconvenient because it can't be dragged aside to access other windows. This CL adds a standard window frame on Mac.

BUG=b/19370387

Committed: https://crrev.com/623837584d1f482e84d7704e72b0619c16dc0956
Cr-Commit-Position: refs/heads/master@{#318128}

[Jamie, 2015-02-24 22:42:06]

jamiewalch@chromium.org changed reviewers:
+ garykac@chromium.org

[Jamie, 2015-02-24 22:42:07]

ptal

[Wez, 2015-02-24 23:50:03]

Can we also "fix" the app to apply a black background behind the plugin,
rather than white, please?

On 24 February 2015 at 14:42, <jamiewalch@chromium.org> wrote:

> Reviewers: garykac,
>
> Message:
> ptal
>
> Description:
> Use a framed window on Mac.
>
> Since Mac does not support transparency, having a window with no title bar
> is
> inconvenient because it can't be dragged aside to access other windows.
> This CL
> adds a standard window frame on Mac.
>
> BUG=b/19370387
>
> Please review this at https://codereview.chromium.org/952823003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -1 lines):
>   M remoting/webapp/app_remoting/js/ar_background.js
>
>
> Index: remoting/webapp/app_remoting/js/ar_background.js
> diff --git a/remoting/webapp/app_remoting/js/ar_background.js
> b/remoting/webapp/app_remoting/js/ar_background.js
> index b70736bd131e3250d0d7be1e8c395f542b0b02a0..
> 908f3f3b1a4a957ba12834cffb7a5637daac604c 100644
> --- a/remoting/webapp/app_remoting/js/ar_background.js
> +++ b/remoting/webapp/app_remoting/js/ar_background.js
> @@ -28,7 +28,7 @@ function createWindow(opt_launchData) {
>
>    var windowAttributes = {
>      resizable: false,
> -    frame: 'none',
> +    frame: remoting.platformIsMac() ? 'chrome' : 'none',
>      bounds: {
>        width: typed_screen.availWidth,
>        height: typed_screen.availHeight
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jamie, 2015-02-25 00:08:15]

On 2015/02/24 23:50:03, Wez wrote:
> Can we also "fix" the app to apply a black background behind the plugin,
> rather than white, please?

I don't know... It would make the CL twice as long :)

More seriously, what's your basis for thinking black would be better? Better
contrast against common apps, just aesthetics or something else?

[Wez, 2015-02-25 02:33:46]

Both aesthetics & tendency for common apps to have a pale window
background, so better contrast against a black background. If you think
about common desktop background colours, white is not one of them. :)

On 24 February 2015 at 16:08, <jamiewalch@chromium.org> wrote:

> On 2015/02/24 23:50:03, Wez wrote:
>
>> Can we also "fix" the app to apply a black background behind the plugin,
>> rather than white, please?
>>
>
> I don't know... It would make the CL twice as long :)
>
> More seriously, what's your basis for thinking black would be better?
> Better
> contrast against common apps, just aesthetics or something else?
>
> https://codereview.chromium.org/952823003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[garykac, 2015-02-25 18:42:32]

lgtm

Any changes to the background color should be in a separate cl.

[garykac, 2015-02-25 18:42:32]

lgtm

Any changes to the background color should be in a separate cl.

[Jamie, 2015-02-25 21:14:42]

The CQ bit was checked by jamiewalch@chromium.org

[commit-bot: I haz the power, 2015-02-25 21:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952823003/1

[commit-bot: I haz the power, 2015-02-25 22:31:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-25 22:45:03]

Patchset 1 (id:??) landed as
https://crrev.com/623837584d1f482e84d7704e72b0619c16dc0956
Cr-Commit-Position: refs/heads/master@{#318128}