Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 952813002: InlinedVisitor: Migrate frame to use inlined tracing (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, dcheng, Inactive, timvolodine
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate frame to use inlined tracing Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ R=oilpan-reviews BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190740

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M Source/core/frame/BarProp.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/BarProp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Console.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Console.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ConsoleBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMTimer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMTimerCoordinator.h View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindowProperty.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindowProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/EventHandlerRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/EventHandlerRegistry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Frame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameConsole.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameConsole.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameDestructionObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameDestructionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameOwner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameViewAutoSizeInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameViewAutoSizeInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/History.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/History.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ImageBitmap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/ImageBitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/Location.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/PinchViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/PinchViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/PlatformEventDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/PlatformEventDispatcher.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/RemoteDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/RemoteFrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Screen.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Screen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/TopControls.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/TopControls.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-24 07:49:17 UTC) #1
tkent
lgtm
5 years, 10 months ago (2015-02-24 07:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952813002/1
5 years, 10 months ago (2015-02-24 07:59:57 UTC) #5
haraken
LGTM https://codereview.chromium.org/952813002/diff/1/Source/core/frame/DOMTimerCoordinator.h File Source/core/frame/DOMTimerCoordinator.h (right): https://codereview.chromium.org/952813002/diff/1/Source/core/frame/DOMTimerCoordinator.h#newcode52 Source/core/frame/DOMTimerCoordinator.h:52: DECLARE_TRACE(); // Oilpan. Remove the comment. https://codereview.chromium.org/952813002/diff/1/Source/core/frame/DOMWindow.h File ...
5 years, 10 months ago (2015-02-24 08:47:26 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 10:37:57 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190740

Powered by Google App Engine
This is Rietveld 408576698