Issue 952783003: Revert of When sanitizing serialized navigation entries also take iframes into account

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 952783003: Revert of When sanitizing serialized navigation entries also take iframes into account (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 10 months ago

Reviewers:
marja

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of When sanitizing serialized navigation entries also take iframes into account (patchset #1 id:1 of https://codereview.chromium.org/948013002/) Reason for revert: regresses startup performance too much Original issue's description: > When sanitizing serialized navigation entries also take iframes into account > > The state of the iframes is encoded in the page state, so we need to > decode the page state and recursively check it. > > BUG=422871 > R=marja@chromium.org > > Committed: https://crrev.com/7b6465936e610ec9b452446ca4c4718d07f4095c > Cr-Commit-Position: refs/heads/master@{#317595} TBR=marja@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=422871 Committed: https://crrev.com/6bf74016ffb251b107218a1ace3640b205dede6b Cr-Commit-Position: refs/heads/master@{#317774}

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -35 lines)			Patch
	M	components/sessions/content/content_serialized_navigation_driver.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
	M	content/public/common/page_state.cc	View		3 chunks	+1 line, -30 lines	0 comments	Download

Total messages: 4 (0 generated)

jochen (gone - plz use gerrit)

Created Revert of When sanitizing serialized navigation entries also take iframes into account

5 years, 10 months ago (2015-02-24 09:43:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952783003/1

5 years, 10 months ago (2015-02-24 09:44:15 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-24 09:45:21 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6bf74016ffb251b107218a1ace3640b205dede6b
Cr-Commit-Position: refs/heads/master@{#317774}