Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 952733002: key_silk_cases/list_animation_simple.html: there should always be exactly 1 layout. (Closed)

Created:
5 years, 10 months ago by benjhayden
Modified:
5 years, 10 months ago
Reviewers:
eae, Sami
CC:
chromium-reviews, nduca, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

key_silk_cases/list_animation_simple.html: there should always be exactly 1 layout. Merge script tags and also use body {display:none;} then document.body.style.display = 'block'. Also move the page from the web into the repo. This should reduce the noisiness of thread_times.key_silk_cases layout_avg somewhat. BUG=459668 Committed: https://crrev.com/db1eb5491511f4820c86e2ed5203bafe41222e6f Cr-Commit-Position: refs/heads/master@{#318218}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -1 line) Patch
M tools/perf/page_sets/key_silk_cases.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/perf/page_sets/key_silk_cases/list_animation_simple.html View 1 chunk +226 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
benjhayden
5 years, 10 months ago (2015-02-23 23:05:02 UTC) #3
eae
LGTM
5 years, 10 months ago (2015-02-23 23:24:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952733002/20001
5 years, 10 months ago (2015-02-25 19:20:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45498)
5 years, 10 months ago (2015-02-25 19:49:51 UTC) #8
benjhayden
Sami: ownership review?
5 years, 10 months ago (2015-02-25 21:11:09 UTC) #10
Sami
rs lgtm.
5 years, 10 months ago (2015-02-26 11:49:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952733002/20001
5 years, 10 months ago (2015-02-26 11:50:20 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-26 11:59:36 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 12:00:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db1eb5491511f4820c86e2ed5203bafe41222e6f
Cr-Commit-Position: refs/heads/master@{#318218}

Powered by Google App Engine
This is Rietveld 408576698