Revert "dart2js: Avoid escaping in strings if it's not necessary."

pkg/compiler/lib/src/js/builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Utilities for building JS ASTs at runtime.  Contains a builder class
 // and a parser that parses part of the language.
 
 part of js_ast;
 
 
@@ skipping 271 matching lines @@
    * context that expects a template.
    */
   Template expressionTemplateYielding(Node ast) {
     return new Template.withExpressionResult(ast);
   }
 
   Template statementTemplateYielding(Node ast) {
     return new Template.withStatementResult(ast);
   }
 
-  static RegExp _stringEscapeRegExp =
-      new RegExp('\\\\|\n|"|\b|\t|\v|\u2028|\u2029');
-
   /// Creates a literal js string from [value].
   LiteralString escapedString(String value) {
-    // Relevant sections of ECMA-262:
-    //
-    //     7.3 Line Terminators
-    //       LineTerminator ::
-    //          <LF>
-    //          <CR>
-    //          <LS>
-    //          <PS>
-    //
-    //     7.8.4 String Literals
-    //       StringLiteral ::
-    //          " DoubleStringCharacters? "
-    //          ' SingleStringCharacters? '
-    //
-    //       DoubleStringCharacters ::
-    //          DoubleStringCharacter DoubleStringCharacters?
-    //
-    //       DoubleStringCharacter ::
-    //          SourceCharacter but not one of " or \ or LineTerminator
-    //          \ EscapeSequence
-    //          LineContinuation
-    //
+   // Start by escaping the backslashes.
+    String escaped = value.replaceAll('\\', '\\\\');
     // Do not escape unicode characters and ' because they are allowed in the
     // string literal anyway.
-    String escaped = value.replaceAllMapped(_stringEscapeRegExp, (Match match) {
+    escaped = escaped.replaceAllMapped(new RegExp('\n|"|\b|\t|\v'), (match) {
       switch (match.group(0)) {
-        case "\\" : return r"\\";
         case "\n" : return r"\n";
         case "\"" : return r'\"';
         case "\b" : return r"\b";
         case "\t" : return r"\t";
         case "\f" : return r"\f";
         case "\v" : return r"\v";
-        case "\u2028" : return r"\u2028";
-        case "\u2029" : return r"\u2029";
       }
     });
     LiteralString result = string(escaped);
     // We don't escape ' under the assumption that the string is wrapped
     // into ". Verify that assumption.
     assert(result.value.codeUnitAt(0) == '"'.codeUnitAt(0));
     return result;
   }
 
   /// Creates a literal js string from [value].
@@ skipping 1013 matching lines @@
 
   Catch parseCatch() {
     expectCategory(LPAREN);
     Declaration errorName = parseVariableDeclaration();
     expectCategory(RPAREN);
     expectCategory(LBRACE);
     Block body = parseBlock();
     return new Catch(errorName, body);
   }
 }