Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 952623002: Revert of Restore FileSystemProviderApiTest.BigFile. (Closed)

Created:
5 years, 10 months ago by flackr
Modified:
5 years, 10 months ago
Reviewers:
mtomasz, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restore FileSystemProviderApiTest.BigFile. (patchset #1 id:1 of https://codereview.chromium.org/925213002/) Reason for revert: FileSystemProviderApiTest.BigFile is still failing, about 98% of runs on cros_trunk bot. Original issue's description: > Restore FileSystemProviderApiTest.BigFile. > > This test is not more flaky than other tests. There seem to be some test > launching issue. Sometimes api tests do not start from time to time. It's > not common though. > > Enabling the test, as it's better to have flaky test than no test. The issue > with launching tests is tracked separately. > > TEST=browser_tests: *FileSystemProviderApiTest.BigFile* > BUG=458122 > > Committed: https://crrev.com/fae5f10535ecd3215d1e924505301562ed49744a > Cr-Commit-Position: refs/heads/master@{#316429} TBR=hirono@chromium.org,mtomasz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458122 Committed: https://crrev.com/95a5170e59f45c65403a833d0f12cbd6922d7d96 Cr-Commit-Position: refs/heads/master@{#317600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
flackr
Created Revert of Restore FileSystemProviderApiTest.BigFile.
5 years, 10 months ago (2015-02-23 17:08:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952623002/1
5 years, 10 months ago (2015-02-23 17:09:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 17:09:42 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:10:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95a5170e59f45c65403a833d0f12cbd6922d7d96
Cr-Commit-Position: refs/heads/master@{#317600}

Powered by Google App Engine
This is Rietveld 408576698