Refresh the autofill wallet switch summary.

Refresh the autofill wallet switch summary as needed.

(in the top level Autofill Preferences page)

BUG=461006
Committed: https://crrev.com/7c665abd53c837cffaab0e0b62b2a2960dc58888
Cr-Commit-Position: refs/heads/master@{#318828}

[Evan Stade, 2015-02-23 20:07:20]

estade@chromium.org changed reviewers:
+ aurimas@chromium.org

[Evan Stade, 2015-02-24 00:52:04]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-02-24 00:52:06]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2015-02-26 23:08:14]

On 2015/02/23 20:08:13, Evan Stade wrote:

ping

[aurimas (slooooooooow), 2015-02-26 23:12:48]

lgtm

[Evan Stade, 2015-02-26 23:13:53]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-02-26 23:15:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952613003/20001

[Evan Stade, 2015-02-27 00:08:55]

estade@chromium.org changed reviewers:
+ newt@chromium.org

[Evan Stade, 2015-02-27 00:08:56]

+newt for OWNERS

[newt (away), 2015-02-27 01:05:22]

https://codereview.chromium.org/952613003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
(right):

https://codereview.chromium.org/952613003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java:136:
if (!PersonalDataManager.isWalletImportFeatureAvailable()) {
Could the value of PersonalDataManager.isWalletImportFeatureAvailable() change?
If it changed from false to true, this would crash on line walletPref, since
PREF_AUTOFILL_WALLET would have been previously removed and walletPref would be
null.

If it can't change, then let's put the logic to remove the preference in the
onCreate() method and just change the summary in this method (with a null check,
of course).

[newt (away), 2015-02-27 01:08:13]

*would crash on line 139

[commit-bot: I haz the power, 2015-02-27 01:24:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-27 01:24:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2015-02-28 00:06:07]

https://codereview.chromium.org/952613003/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java
(right):

https://codereview.chromium.org/952613003/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java:136:
if (!PersonalDataManager.isWalletImportFeatureAvailable()) {
On 2015/02/27 01:05:22, newt wrote:
> Could the value of PersonalDataManager.isWalletImportFeatureAvailable()
change?
> If it changed from false to true, this would crash on line walletPref, since
> PREF_AUTOFILL_WALLET would have been previously removed and walletPref would
be
> null.
> 
> If it can't change, then let's put the logic to remove the preference in the
> onCreate() method and just change the summary in this method (with a null
check,
> of course).

Indeed it can change, for example if you sign in or out of sync. Updated the
code to handle such changes.

[newt (away), 2015-02-28 00:55:14]

lgtm

[Evan Stade, 2015-03-03 01:59:31]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-03-03 01:59:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
aurimas@chromium.org, newt@chromium.org
Link to the patchset: https://codereview.chromium.org/952613003/#ps60001 (title:
"resolve merge conflict")

[commit-bot: I haz the power, 2015-03-03 02:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/952613003/60001

[commit-bot: I haz the power, 2015-03-03 03:22:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-03 03:23:01]

Patchset 4 (id:??) landed as
https://crrev.com/7c665abd53c837cffaab0e0b62b2a2960dc58888
Cr-Commit-Position: refs/heads/master@{#318828}