Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2822)

Unified Diff: chrome/browser/errorpage_browsertest.cc

Issue 952563003: Reinstate the error code to main content area + bug fixes on security / network interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust vertical alignment of details button, remove net error string prefix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/errorpage_browsertest.cc
diff --git a/chrome/browser/errorpage_browsertest.cc b/chrome/browser/errorpage_browsertest.cc
index 6c4708af8908d112f60e780c2325077775fd0069..2ae8dbeae36c761e3b46caedaff156631b814739 100644
--- a/chrome/browser/errorpage_browsertest.cc
+++ b/chrome/browser/errorpage_browsertest.cc
@@ -941,7 +941,7 @@ IN_PROC_BROWSER_TEST_F(ErrorPageAutoReloadTest, ManualReloadNotSuppressed) {
EXPECT_EQ(2, interceptor()->requests());
ToggleHelpBox(browser());
- EXPECT_TRUE(IsDisplayingNetError(browser(), net::ERR_CONNECTION_RESET));
+ EXPECT_TRUE(IsDisplayingText(browser(), "error.page.auto.reload"));
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -949,7 +949,7 @@ IN_PROC_BROWSER_TEST_F(ErrorPageAutoReloadTest, ManualReloadNotSuppressed) {
web_contents->GetMainFrame()->ExecuteJavaScript(
base::ASCIIToUTF16("document.getElementById('reload-button').click();"));
nav_observer.Wait();
- EXPECT_FALSE(IsDisplayingNetError(browser(), net::ERR_CONNECTION_RESET));
+ EXPECT_FALSE(IsDisplayingText(browser(), "error.page.auto.reload"));
}
// Interceptor that fails all requests with net::ERR_ADDRESS_UNREACHABLE.
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/security_warnings/images/1x/brokenssl_red.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698