Issue 952533002: Don't do XKB lookup for DomCode::NONE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 952533002: Don't do XKB lookup for DomCode::NONE. (Closed)

Created:
5 years, 10 months ago by kpschoedel

Modified:
5 years, 10 months ago

Reviewers:
spang

CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't do XKB lookup for DomCode::NONE. This avoids a spurious log error. BUG=460889 Committed: https://crrev.com/fc3f8c65d471593e0bcc8ddde4880cc549370719 Cr-Commit-Position: refs/heads/master@{#317609}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952533002/1

5 years, 10 months ago (2015-02-23 17:53:34 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 18:23:53 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fc3f8c65d471593e0bcc8ddde4880cc549370719
Cr-Commit-Position: refs/heads/master@{#317609}