Simplify HTMLMediaElement::textTrackModeChanged

Source/core/html/track/TextTrack.cpp

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2011, 2012, 2013 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 162 matching lines @@
     // because they will no longer be accessible from the cues() function.
     if (mode == disabledKeyword() && cueTimeline() && m_cues)
         cueTimeline()->removeCues(this, m_cues.get());
 
     if (mode != showingKeyword() && m_cues)
         for (size_t i = 0; i < m_cues->length(); ++i)
             m_cues->item(i)->removeDisplayTree();
 
     m_mode = mode;
 
+    if (mode != disabledKeyword() && readinessState() == Loaded) {

[philipj_slow, 2015/02/25 15:52:14]

This was just copied, but is there any reason ReadinessState Loading isn't
included here? AFAICT there isn't anything that would add any missed cues later.

[fs, 2015/02/25 16:26:11]

If Loading, then cues will make their way to the track via the loader and arrive
via addListOfCues.

+        if (m_cues && cueTimeline())
+            cueTimeline()->addCues(this, m_cues.get());
+    }
+
     if (mediaElement())
         mediaElement()->textTrackModeChanged(this);
 }
 
 TextTrackCueList* TextTrack::cues()
 {
     // 4.8.10.12.5 If the text track mode ... is not the text track disabled mode,
     // then the cues attribute must return a live TextTrackCueList object ...
     // Otherwise, it must return null. When an object is returned, the
     // same object must be returned each time.
@@ skipping 256 matching lines @@
 DEFINE_TRACE(TextTrack)
 {
     visitor->trace(m_cues);
     visitor->trace(m_regions);
     visitor->trace(m_trackList);
     TrackBase::trace(visitor);
     EventTargetWithInlineData::trace(visitor);
 }
 
 } // namespace blink