src/isolate.cc - Issue 952483002: NewError no longer returns a MaybeObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 952483002: NewError no longer returns a MaybeObject. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@reland

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 2c8367d7a1b26a480dd9be27dc0ff14fc2ac0fda..68aa2f363b5136f6308e836915c30e786976d3e2 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -739,10 +739,7 @@ void Isolate::ReportFailedAccessCheck(Handle<JSObject> receiver,

v8::AccessType type) {

if (!thread_local_top()->failed_access_check_callback_) {

Handle<String> message = factory()->InternalizeUtf8String("no access");

- Handle<Object> error;

- ASSIGN_RETURN_ON_EXCEPTION_VALUE(

- this, error, factory()->NewTypeError(message), /* void */);

- ScheduleThrow(*error);

+ ScheduleThrow(*factory()->NewTypeError(message));

return;

}

« no previous file with comments | « src/isolate.h ('k') | src/json-parser.h » ('j') | no next file with comments »