Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 952483002: NewError no longer returns a MaybeObject. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@reland
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

NewError no longer returns a MaybeObject. We no longer expect NewError to return an empty handle to signal termination exception, since TryCall simply requests a new terminate exception interrupt. BUG=chromium:403509 LOG=N Committed: https://crrev.com/c5d55550d8295f28e9a3e436111c9154969173f8 Cr-Commit-Position: refs/heads/master@{#26811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -138 lines) Patch
M src/accessors.cc View 3 chunks +4 lines, -22 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -9 lines 0 comments Download
M src/factory.h View 1 chunk +22 lines, -24 lines 0 comments Download
M src/factory.cc View 4 chunks +26 lines, -28 lines 0 comments Download
M src/isolate.h View 1 chunk +6 lines, -12 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/parser.cc View 1 chunk +14 lines, -18 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 10 months ago (2015-02-23 15:12:40 UTC) #2
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-23 15:29:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952483002/1
5 years, 10 months ago (2015-02-24 08:39:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952483002/1
5 years, 10 months ago (2015-02-24 08:39:58 UTC) #6
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-24 09:01:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 09:01:42 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 09:01:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5d55550d8295f28e9a3e436111c9154969173f8
Cr-Commit-Position: refs/heads/master@{#26811}

Powered by Google App Engine
This is Rietveld 408576698