extensions/common/extension_messages.h - Issue 952473002: Add frameId to executeScript/insertCSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension_messages.h

Issue 952473002: Add frameId to executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a few nits (review up to comment 16) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/extension_messages.h

diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h

index aee505c44a9d4b8a71a52d1648c842b9b56a2ced..c79bd8335c2376c8d1fc450e33691744d0d410fc 100644

--- a/extensions/common/extension_messages.h

+++ b/extensions/common/extension_messages.h

@@ -119,9 +119,14 @@ IPC_STRUCT_BEGIN(ExtensionMsg_ExecuteCode_Params)

// The webview guest source who calls to execute code.

IPC_STRUCT_MEMBER(GURL, webview_src)

- // Whether to inject into all frames, or only the root frame.

+ // Whether to inject into the selected frame and its child frames, or only the

+ // selected frame.

IPC_STRUCT_MEMBER(bool, all_frames)

+ // Frame where the code should be executed. 0 for the root frame, a positive

+ // number for a specific child frame.

+ IPC_STRUCT_MEMBER(int, frame_id)

// Whether to inject into about:blank (sub)frames.

IPC_STRUCT_MEMBER(bool, match_about_blank)