extensions/browser/script_executor.h - Issue 952473002: Add frameId to executeScript/insertCSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/script_executor.h

Issue 952473002: Add frameId to executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a few nits (review up to comment 16) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/script_executor.h

diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h

index c4ecb008d06efec79f9c802e14dc4afafbd85991..daa812668c6701458d115b5c0f76c965c6402390 100644

--- a/extensions/browser/script_executor.h

+++ b/extensions/browser/script_executor.h

@@ -44,7 +44,7 @@ class ScriptExecutor {

// The scope of the script injection across the frames.

enum FrameScope {

- TOP_FRAME,

+ SINGLE_FRAME,

ALL_FRAMES,

};

@@ -89,6 +89,7 @@ class ScriptExecutor {

ScriptType script_type,

const std::string& code,

FrameScope frame_scope,

+ int frame_id,

MatchAboutBlank match_about_blank,

UserScript::RunLocation run_at,

WorldType world_type,