chrome/browser/extensions/execute_script_apitest.cc - Issue 952473002: Add frameId to executeScript/insertCSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/execute_script_apitest.cc

Issue 952473002: Add frameId to executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a few nits (review up to comment 16) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/execute_script_apitest.cc

diff --git a/chrome/browser/extensions/execute_script_apitest.cc b/chrome/browser/extensions/execute_script_apitest.cc

index 063736cab95f972bc1467cecf252252d3f63fce5..6a3e55295b1519dbb14deb9866ce3782a55aa396 100644

--- a/chrome/browser/extensions/execute_script_apitest.cc

+++ b/chrome/browser/extensions/execute_script_apitest.cc

@@ -36,6 +36,12 @@ IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, ExecuteScriptInFrame) {

ASSERT_TRUE(RunExtensionTest("executescript/in_frame")) << message_;

}

+IN_PROC_BROWSER_TEST_F(ExecuteScriptApiTest, ExecuteScriptByFrameId) {

+ SetupDelayedHostResolver();

+ ASSERT_TRUE(StartEmbeddedTestServer());

+ ASSERT_TRUE(RunExtensionTest("executescript/frame_id")) << message_;

// Fails often on Windows.

// http://crbug.com/174715

#if defined(OS_WIN)