Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: extensions/common/extension_messages.h

Issue 952473002: Add frameId to executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert change to error message, moved to https://codereview.chromium.org/945743003/ Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_messages.h
diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h
index aee505c44a9d4b8a71a52d1648c842b9b56a2ced..c79bd8335c2376c8d1fc450e33691744d0d410fc 100644
--- a/extensions/common/extension_messages.h
+++ b/extensions/common/extension_messages.h
@@ -119,9 +119,14 @@ IPC_STRUCT_BEGIN(ExtensionMsg_ExecuteCode_Params)
// The webview guest source who calls to execute code.
IPC_STRUCT_MEMBER(GURL, webview_src)
- // Whether to inject into all frames, or only the root frame.
+ // Whether to inject into the selected frame and its child frames, or only the
+ // selected frame.
IPC_STRUCT_MEMBER(bool, all_frames)
+ // Frame where the code should be executed. 0 for the root frame, a positive
+ // number for a specific child frame.
+ IPC_STRUCT_MEMBER(int, frame_id)
nasko 2015/02/23 18:39:02 Since this is routing id, let's name it clearly: s
robwu 2015/02/23 18:59:53 This is currently a routing ID, but in the future
+
// Whether to inject into about:blank (sub)frames.
IPC_STRUCT_MEMBER(bool, match_about_blank)

Powered by Google App Engine
This is Rietveld 408576698