Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: extensions/browser/script_executor.h

Issue 952473002: Add frameId to executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert change to error message, moved to https://codereview.chromium.org/945743003/ Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/script_executor.h
diff --git a/extensions/browser/script_executor.h b/extensions/browser/script_executor.h
index c4ecb008d06efec79f9c802e14dc4afafbd85991..70c85b3f07a329b08cdeb08ecac41cfe453b358a 100644
--- a/extensions/browser/script_executor.h
+++ b/extensions/browser/script_executor.h
@@ -44,8 +44,8 @@ class ScriptExecutor {
// The scope of the script injection across the frames.
enum FrameScope {
- TOP_FRAME,
ALL_FRAMES,
+ ONE_FRAME,
not at google - send to devlin 2015/02/23 20:41:24 Why change the order? also I believe "single" is t
robwu 2015/02/23 21:54:06 Done (rename & re-order) (I re-ordered because of
};
// Whether to insert the script in about: frames when its origin matches
@@ -89,6 +89,7 @@ class ScriptExecutor {
ScriptType script_type,
const std::string& code,
FrameScope frame_scope,
+ int frame_id,
MatchAboutBlank match_about_blank,
UserScript::RunLocation run_at,
WorldType world_type,

Powered by Google App Engine
This is Rietveld 408576698