chrome/browser/chromeos/accessibility/accessibility_manager.cc - Issue 952473002: Add frameId to executeScript/insertCSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_manager.cc

Issue 952473002: Add frameId to executeScript/insertCSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert change to error message, moved to https://codereview.chromium.org/945743003/ Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/accessibility/accessibility_manager.cc

diff --git a/chrome/browser/chromeos/accessibility/accessibility_manager.cc b/chrome/browser/chromeos/accessibility/accessibility_manager.cc

index 2fcc539c62fb04802ed682a5ee936ba412979772..f8795bdff4c15b111d70b11c0d84686b68cbc538 100644

--- a/chrome/browser/chromeos/accessibility/accessibility_manager.cc

+++ b/chrome/browser/chromeos/accessibility/accessibility_manager.cc

@@ -140,6 +140,7 @@ class ContentScriptLoader {

params.code = data;

params.run_at = extensions::UserScript::DOCUMENT_IDLE;

params.all_frames = true;

+ params.frame_id = 0;

not at google - send to devlin 2015/02/23 20:41:23 Hm, would be good to use ScriptExecutor here. Some

params.match_about_blank = false;

params.in_main_world = false;

@@ -209,6 +210,7 @@ void InjectChromeVoxContentScript(

params.code = "window.INJECTED_AFTER_LOAD = true;";

params.run_at = extensions::UserScript::DOCUMENT_IDLE;

params.all_frames = true;

+ params.frame_id = 0;

params.match_about_blank = false;

params.in_main_world = false;

render_view_host->Send(new ExtensionMsg_ExecuteCode(