Add UMA to track permission changes from the content settings menu

chrome/browser/ui/webui/options/content_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
+#include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
 #include "chrome/browser/extensions/extension_special_storage_policy.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
@@ skipping 1387 matching lines @@
   if (type_string == kZoomContentType) {
     RemoveZoomLevelException(args);
     return;
   }
 
   ContentSettingsType type = ContentSettingsTypeFromGroupName(type_string);
   if (type == CONTENT_SETTINGS_TYPE_MEDIASTREAM)
     RemoveMediaException(args);
   else
     RemoveExceptionFromHostContentSettingsMap(args, type);
+  ContentSettingsTypeHistogram histogram_value =

[Finnur, 2015/02/23 14:15:27]

nit: Line-break above (looks as-is a bit like part of the else clause).

[Miguel Garcia, 2015/02/23 14:35:21]

Done.

+      ContentSettingTypeToHistogramValue(type);

[Finnur, 2015/02/23 14:15:27]

In the other place, you DCHECK if you get an invalid value. Maybe follow suit
here?

[Miguel Garcia, 2015/02/23 14:35:21]

Done.

+
+  UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Menu.PermissionChanged",
+                            histogram_value,
+                            CONTENT_SETTINGS_HISTOGRAM_NUM_TYPES);
+
+  UMA_HISTOGRAM_ENUMERATION(
+      "WebsiteSettings.ContentSettings.PermissionChanged.Ask", histogram_value,

[Finnur, 2015/02/23 14:15:27]

Same here: s/Ask/Reset/

[Miguel Garcia, 2015/02/23 14:35:21]

Done.

+      CONTENT_SETTINGS_HISTOGRAM_NUM_TYPES);
 }
 
 void ContentSettingsHandler::SetException(const base::ListValue* args) {
   std::string type_string;
   CHECK(args->GetString(0, &type_string));
   std::string mode;
   CHECK(args->GetString(1, &mode));
   std::string pattern;
   CHECK(args->GetString(2, &pattern));
   std::string setting;
@@ skipping 164 matching lines @@
 
   // Exceptions apply only when the feature is enabled.
   PrefService* prefs = user_prefs::UserPrefs::Get(GetBrowserContext(web_ui()));
   bool enable_exceptions = prefs->GetBoolean(prefs::kEnableDRM);
   web_ui()->CallJavascriptFunction(
       "ContentSettings.enableProtectedContentExceptions",
       base::FundamentalValue(enable_exceptions));
 }
 
 }  // namespace options