The tracing service sometimes creates corrupt data

The tracing service sometimes creates corrupt data

We need to use a smarter function for writing data into the data pipe because
it might be full.

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/34a3f809c881ccf81bcde8a912431240f6b9c60f

[jamesr, 2015-02-26 00:25:22]

lgtm

https://codereview.chromium.org/952413002/diff/1/services/tracing/trace_data_...
File services/tracing/trace_data_sink.cc (right):

https://codereview.chromium.org/952413002/diff/1/services/tracing/trace_data_...
services/tracing/trace_data_sink.cc:20:
mojo::common::BlockingCopyFromString(kStart, pipe_);
since we're calling this 3 times could you put a using statement up top? i.e.
around line 10 do

using mojo::common::BlockingCopyFromString

then drop the ns from these

[abarth-chromium, 2015-02-26 02:54:12]

https://codereview.chromium.org/952413002/diff/1/services/tracing/trace_data_...
File services/tracing/trace_data_sink.cc (right):

https://codereview.chromium.org/952413002/diff/1/services/tracing/trace_data_...
services/tracing/trace_data_sink.cc:20:
mojo::common::BlockingCopyFromString(kStart, pipe_);
On 2015/02/26 at 00:25:22, jamesr wrote:
> since we're calling this 3 times could you put a using statement up top? i.e.
around line 10 do
> 
> using mojo::common::BlockingCopyFromString
> 
> then drop the ns from these

Will do.  Thanks!

[abarth-chromium, 2015-02-26 17:18:27]

Committed patchset #1 (id:1) manually as
34a3f809c881ccf81bcde8a912431240f6b9c60f (presubmit successful).

[abarth-chromium, 2015-02-26 17:31:34]

Oh man, I forgot to do the "using"