Requiem for client_screen.js

remoting/webapp/crd/js/desktop_connected_view.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling user-facing aspects of the client session.
  */
 
 'use strict';
@@ skipping 42 matching lines @@
 
   /** @type {string} @private */
   this.defaultRemapKeys_ = defaultRemapKeys;
 
   /**
    * Called when the UI is finished initializing.
    * @type {function(remoting.Error, remoting.ClientPlugin):void}
    */
   this.onInitialized_ = onInitialized;
 
-  /** @type {function(boolean=):void} @private */
-  this.callOnFullScreenChanged_ = this.onFullScreenChanged_.bind(this)
-
   /** @private */
   this.callPluginLostFocus_ = this.pluginLostFocus_.bind(this);
   /** @private */
   this.callPluginGotFocus_ = this.pluginGotFocus_.bind(this);
   /** @type {Element} @private */
   this.debugRegionContainer_ =
       this.container_.querySelector('.debug-region-container');
 
   /** @type {Element} @private */
   this.mouseCursorOverlay_ =
       this.container_.querySelector('.mouse-cursor-overlay');
 
   /** @private {remoting.DesktopViewport} */
   this.viewport_ = null;
 
   /** @type {Element} */
   var img = this.mouseCursorOverlay_;
   /** @param {Event} event @private */
   this.updateMouseCursorPosition_ = function(event) {
     img.style.top = event.offsetY + 'px';
     img.style.left = event.offsetX + 'px';
   };
 
   /** @type {remoting.VideoFrameRecorder} @private */
   this.videoFrameRecorder_ = null;
+
+  /** private {base.Disposable} */
+  this.eventHooks_ = null;
 };
 
 // The mode of this session.
 /** @enum {number} */
 remoting.DesktopConnectedView.Mode = {
   IT2ME: 0,
   ME2ME: 1,
   APP_REMOTING: 2
 };
 
@@ skipping 114 matching lines @@
 
   this.plugin_.setMouseCursorHandler(this.updateMouseCursorImage_.bind(this));
 
   this.onInitialized_(remoting.Error.NONE, this.plugin_);
 };
 
 /**
  * This is a callback that gets called when the window is resized.
  *
  * @return {void} Nothing.
+ * @private.
  */
-remoting.DesktopConnectedView.prototype.onResize = function() {
+remoting.DesktopConnectedView.prototype.onResize_ = function() {
   if (this.viewport_) {
     this.viewport_.onResize();
   }
 };
 
 /**
+ * Called when the app window is hidden.
+ * @return {void} Nothing.
+ */
+remoting.DesktopConnectedView.prototype.onVisibilityChanged_ = function() {
+  this.pauseVideo(document.hidden);
+};
+
+/**
  * Callback that the plugin invokes to indicate when the connection is
  * ready.
  *
  * @param {boolean} ready True if the connection is ready.
  */
 remoting.DesktopConnectedView.prototype.onConnectionReady = function(ready) {
   if (!ready) {
     this.container_.classList.add('session-client-inactive');
   } else {
     this.container_.classList.remove('session-client-inactive');
@@ skipping 19 matching lines @@
 
   this.updateClientSessionUi_(null);
 };
 
 /**
  * @param {remoting.ClientSession} clientSession The active session, or null if
  *     there is no connection.
  */
 remoting.DesktopConnectedView.prototype.updateClientSessionUi_ = function(
     clientSession) {
-  if (clientSession == null) {
+  if (clientSession === null) {
     if (remoting.windowFrame) {
       remoting.windowFrame.setDesktopConnectedView(null);
     }
     if (remoting.toolbar) {
       remoting.toolbar.setDesktopConnectedView(null);
     }
     if (remoting.optionsMenu) {
       remoting.optionsMenu.setDesktopConnectedView(null);
     }
 
     document.body.classList.remove('connected');
     this.container_.removeEventListener(
         'mousemove', this.updateMouseCursorPosition_, true);
-    // Stop listening for full-screen events.
-    remoting.fullscreen.removeListener(this.callOnFullScreenChanged_);
-
+    base.dispose(this.eventHooks_);
+    this.eventHooks_ = null;
     base.dispose(this.viewport_);
     this.viewport_ = null;
   } else {
     var scrollerElement = document.getElementById('scroller');
     this.viewport_ = new remoting.DesktopViewport(
         scrollerElement || document.body,
         this.plugin_.hostDesktop(),
         this.host_.options);
     if (remoting.windowFrame) {
       remoting.windowFrame.setDesktopConnectedView(this);
     }
     if (remoting.toolbar) {
       remoting.toolbar.setDesktopConnectedView(this);
     }
     if (remoting.optionsMenu) {
       remoting.optionsMenu.setDesktopConnectedView(this);
     }
 
     document.body.classList.add('connected');
     this.container_.addEventListener(
         'mousemove', this.updateMouseCursorPosition_, true);
     // Activate full-screen related UX.
-    remoting.fullscreen.addListener(this.callOnFullScreenChanged_);
     this.setFocusHandlers_();
+    this.eventHooks_ = new base.Disposables(
+      new base.DomEventHook(window, 'resize', this.onResize_.bind(this), false),
+      new base.DomEventHook(document, 'visibilitychange',
+                            this.onVisibilityChanged_.bind(this), false),
+      new remoting.FullScreen.EventHook(this.onFullScreenChanged_.bind(this))
+    );
   }
 };
 
 /**
  * Constrains the focus to the plugin element.
  * @private
  */
 remoting.DesktopConnectedView.prototype.setFocusHandlers_ = function() {
   this.plugin_.element().addEventListener(
       'focus', this.callPluginGotFocus_, false);
@@ skipping 24 matching lines @@
  * Called when the full-screen status has changed, either via the
  * remoting.Fullscreen class, or via a system event such as the Escape key
  *
  * @param {boolean=} fullscreen True if the app is entering full-screen mode;
  *     false if it is leaving it.
  * @private
  */
 remoting.DesktopConnectedView.prototype.onFullScreenChanged_ = function (
     fullscreen) {
   if (this.viewport_) {
+    // When a window goes full-screen, a resize event is triggered, but the
+    // Fullscreen.isActive call is not guaranteed to return true until the
+    // full-screen event is triggered. In apps v2, the size of the window's
+    // client area is calculated differently in full-screen mode, so register
+    // for both events.
+    this.viewport_.onResize();
     this.viewport_.enableBumpScroll(Boolean(fullscreen));
   }
 };
 
 /**
  * Callback function called when the plugin element gets focus.
  */
 remoting.DesktopConnectedView.prototype.pluginGotFocus_ = function() {
   remoting.clipboard.initiateToHost();
 };
@@ skipping 206 matching lines @@
     for (var i = 0; i < rects.length; ++i) {
       var rect = document.createElement('div');
       rect.classList.add('debug-region-rect');
       rect.style.left = rects[i][0] + 'px';
       rect.style.top = rects[i][1] +'px';
       rect.style.width = rects[i][2] +'px';
       rect.style.height = rects[i][3] + 'px';
       this.debugRegionContainer_.appendChild(rect);
     }
   }
-}
+};