Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: sky/engine/core/rendering/RenderLayer.h

Issue 952343003: Remove some dead RenderLayer code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: remove showLayerTree Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLayer.h
diff --git a/sky/engine/core/rendering/RenderLayer.h b/sky/engine/core/rendering/RenderLayer.h
index 7891e6bbc5cc2a436209f486d82054345ed8bbb4..76ebf529b6025d718bafe604d95b1be5b1c494f8 100644
--- a/sky/engine/core/rendering/RenderLayer.h
+++ b/sky/engine/core/rendering/RenderLayer.h
@@ -214,38 +214,19 @@ public:
}
void updateOrRemoveFilterEffectRenderer();
- void updateSelfPaintingLayer();
void clipToRect(const LayerPaintingInfo&, GraphicsContext*, const ClipRect&, BorderRadiusClippingRule = IncludeSelfForBorderRadius);
void restoreClip(GraphicsContext*, const LayoutRect& paintDirtyRect, const ClipRect&);
private:
- // TODO(ojan): Get rid of this. These are basically layer-tree-only paint phases.
- enum PaintLayerFlags {
- PaintContent,
- };
-
// Bounding box in the coordinates of this layer.
LayoutRect logicalBoundingBox() const;
- void setAncestorChainHasSelfPaintingLayerDescendant();
- void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
-
void setNextSibling(RenderLayer* next) { m_next = next; }
void setPreviousSibling(RenderLayer* prev) { m_previous = prev; }
void setFirstChild(RenderLayer* first) { m_first = first; }
void setLastChild(RenderLayer* last) { m_last = last; }
- void updateHasSelfPaintingLayerDescendant() const;
-
- bool hasSelfPaintingLayerDescendant() const
- {
- if (m_hasSelfPaintingLayerDescendantDirty)
- updateHasSelfPaintingLayerDescendant();
- ASSERT(!m_hasSelfPaintingLayerDescendantDirty);
- return m_hasSelfPaintingLayerDescendant;
- }
-
LayoutPoint renderBoxLocation() const { return renderer()->location(); }
bool shouldBeSelfPaintingLayer() const;
@@ -267,11 +248,6 @@ private:
// FIXME(crbug.com/332791): Self-painting layer should be merged into the overflow-only concept.
unsigned m_isSelfPaintingLayer : 1;
- // If have no self-painting descendants, we don't have to walk our children during painting. This can lead to
- // significant savings, especially if the tree has lots of non-self-painting layers grouped together (e.g. table cells).
- mutable unsigned m_hasSelfPaintingLayerDescendant : 1;
- mutable unsigned m_hasSelfPaintingLayerDescendantDirty : 1;
-
const unsigned m_isRootLayer : 1;
unsigned m_3DTransformedDescendantStatusDirty : 1;
@@ -299,10 +275,4 @@ private:
} // namespace blink
-#ifndef NDEBUG
-// Outside the WebCore namespace for ease of invocation from gdb.
-void showLayerTree(const blink::RenderLayer*);
-void showLayerTree(const blink::RenderObject*);
-#endif
-
#endif // SKY_ENGINE_CORE_RENDERING_RENDERLAYER_H_
« no previous file with comments | « no previous file | sky/engine/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698