Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 952293004: Enable valid tests and remove unavailable tests (Closed)

Created:
5 years, 10 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 9 months ago
Reviewers:
Xianzhu, no sievers
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable valid tests and remove unavailable tests Now valid tests: - WorkerTest except ones using SharedWorkers - MediaSourceTest.ConfigChangeVideo - CrossPlatformAccessibilityBrowserTest - ResourceDispatcherHostBrowserTest.SyncXMLHttpRequest_DuringUnload - ResourceDispatcherHostBrowserTest.CrossSiteAfterCrash - RenderFrameHostManagerTest.ProcessExitWithSwappedOutViews - ScreenOrientationBrowserTest - RenderViewHostTest.BaseURLParam - FileSystemBrowserTestWithLowQuota.QuotaTest - ChildProcessSecurityPolicyInProcessBrowserTest.NoLeak - DomSerializerTests - BookmarkletTest.NonEmptyResult - SignalTest - TracingControllerTest.EnableCaptureAndDisableMonitoring - TracingControllerTest.EnableCaptureAndDisableMonitoringWithFilePath - FrameTreeBrowserTest.NavigateWithLeftoverFrames And unavailable tests: - WebGLConformanceTest - MessagePortTest - OffTheRecordClipboardTest - GpuPixelBrowserTest - RendererAccessibilityTest.EditableTextModeFocusEvents - RendererAccessibilityTest.EditableTextModeFocusNotifications - RenderWidgetTest.OnMsgPaintAtSize - PasswordFormConversionUtilsTest.ValidWebFormElementToPasswordForm - PasswordFormConversionUtilsTest.InvalidWebFormElementToPasswordForm - RenderWidgetHostBrowserTest.GetSnapshotFromRendererTest - BrowserGpuChannelHostFactoryTest BUG=461624, 256238, 338408, 338411, 341995 Committed: https://crrev.com/f123c1b04766936776b72bbc98e8bd823bb6d684 Cr-Commit-Position: refs/heads/master@{#318633}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Re-disable flaky tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -51 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 2 3 4 6 chunks +7 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jaekyun Seok (inactive)
Please review this CL.
5 years, 10 months ago (2015-02-26 05:16:09 UTC) #2
Xianzhu
lgtm
5 years, 10 months ago (2015-02-26 17:03:58 UTC) #4
no sievers
LGTM
5 years, 9 months ago (2015-02-27 20:08:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952293004/70001
5 years, 9 months ago (2015-03-01 21:59:16 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 9 months ago (2015-03-01 22:53:27 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 22:54:21 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f123c1b04766936776b72bbc98e8bd823bb6d684
Cr-Commit-Position: refs/heads/master@{#318633}

Powered by Google App Engine
This is Rietveld 408576698