Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 952283003: No need for special treatment of super in PreParserExpression (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

No need for special treatment of super in PreParserExpression It turned out that we didn't need to treat super in a special way in the pre parser expressions. BUG=None LOG=N R=dslomov@chromium.org Committed: https://crrev.com/92b4eaddbc06282fe3faf7a2720c97579adb55e6 Cr-Commit-Position: refs/heads/master@{#26865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M src/preparser.h View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-25 19:02:57 UTC) #1
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-25 21:43:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/952283003/1
5 years, 10 months ago (2015-02-25 21:44:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 21:47:49 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 21:48:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92b4eaddbc06282fe3faf7a2720c97579adb55e6
Cr-Commit-Position: refs/heads/master@{#26865}

Powered by Google App Engine
This is Rietveld 408576698